Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump alpine from 3.19.1 to 3.20.0 and other updates #62

Merged
merged 18 commits into from
May 23, 2024

Conversation

svengo
Copy link
Owner

@svengo svengo commented May 22, 2024

Update to alpine 3.20.0

https://www.alpinelinux.org/posts/Alpine-3.20.0-released.html

Summary by CodeRabbit

  • Chores
    • Updated Docker base image to alpine:3.30.0 for improved security and performance.
    • Updated Dockerfile links for latest and 0.4.8.11 tags in the README.md for better reference.
    • Introduced a new workflow file codacy.yml for Codacy Security Scan in .github/workflows directory.
    • Scheduled weekly security scans with Codacy and integrated results with GitHub Advanced Security.
    • Adjusted service configuration for daemon in docker-compose.yml.

Copy link

coderabbitai bot commented May 22, 2024

Warning

Rate Limit Exceeded

@svengo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 47 minutes and 41 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 3e0b6d8 and 27a0755.

Walkthrough

The recent update involves changing the base image in the Dockerfile from alpine:3.19.1 to alpine:3.30.0, affecting build-time variables. Additionally, a new workflow file codacy.yml has been added to perform Codacy security scans and integrate the results with GitHub Advanced Security. The docker-compose.yml now reflects a version downgrade for the service configuration of daemon. No changes were made to the declarations of exported or public entities.

Changes

File Change Summary
Dockerfile, README.md Updated base image in Dockerfile to alpine:3.30.0 and Dockerfile links in README for latest and 0.4.8.11
.github/workflows/codacy.yml Added codacy.yml workflow for Codacy Security Scan
docker-compose.yml Downgraded version in docker-compose.yml for the daemon service configuration

In the world of bits and bytes, changes unfold,
Dockerfile shifts, a new image to behold.
Codacy workflows now scan with grace,
GitHub security, a strong embrace.
Docker-compose steps back in time,
Code changes dance, a whimsical rhyme.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (3)
README.md (3)

28-28: Consider rephrasing for conciseness.

Instead of "I will be rebuilding the image on a regular basis to include updated alpine packages with important security fixes," consider "I will regularly rebuild the image to include updated Alpine packages with important security fixes."


Line range hint 142-142: Add a comma for clarity.

- Please report any problems as issue on github:
+ Please report any problems as an issue on GitHub,

Line range hint 145-145: Add a comma between interjections.

- Thanks Thanks to [Natanael Copa](https://github.com/ncopa) for [su-exec](https://github.com/ncopa/su-exec) and the [Tor Project](https://www.torproject.org/).
+ Thanks, thanks to [Natanael Copa](https://github.com/ncopa) for [su-exec](https://github.com/ncopa/su-exec) and the [Tor Project](https://www.torproject.org/).
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 7093e9d and 18a81c1.
Files selected for processing (2)
  • Dockerfile (1 hunks)
  • README.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • Dockerfile
Additional Context Used
LanguageTool (3)
README.md (3)

Near line 28: ‘on a regular basis’ might be wordy. Consider a shorter alternative.
Context: ...erfile) I will be rebuilding the image on a regular basis to include updated alpine packages with...


Near line 142: Consider adding a comma here.
Context: ...o work with an IPv6 address. # Feedback Please report any problems as issue on github:...


Near line 145: Consider adding a comma between these interjections.
Context: .../github.com/svengo/docker-tor/issues # Thanks Thanks to [Natanael Copa](https://github.com/n...

Markdownlint (15)
README.md (15)

26: Expected: dash; Actual: asterisk
Unordered list style


70: Expected: 0 or 2; Actual: 1
Trailing spaces


78: Expected: 0 or 2; Actual: 1
Trailing spaces


24: Expected: 1; Actual: 2
Multiple consecutive blank lines


25: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


142: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


145: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


13: null
Multiple top-level headings in the same document


25: null
Multiple top-level headings in the same document


30: null
Multiple top-level headings in the same document


142: null
Multiple top-level headings in the same document


145: null
Multiple top-level headings in the same document


26: null
Lists should be surrounded by blank lines


143: null
Bare URL used


86: Missing link or image reference definition: ":port"
Reference links and images should use a label that is defined

README.md Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 18a81c1 and 025abed.
Files selected for processing (1)
  • Dockerfile (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • Dockerfile

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Outside diff range and nitpick comments (1)
README.md (1)

Line range hint 89-89: Consider adding a comma after "omitted" for better readability.

- If /MASK is omitted then this policy just applies to the host given.
+ If /MASK is omitted, then this policy just applies to the host given.
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 025abed and cf6d475.
Files selected for processing (1)
  • README.md (3 hunks)
Additional Context Used
LanguageTool (4)
README.md (4)

Near line 31: ‘on a regular basis’ might be wordy. Consider a shorter alternative.
Context: ...rfile) I will be rebuilding this image on a regular basis to include updated alpine packages with...


Near line 55: Unpaired symbol: ‘'’ seems to be missing
Context: ...environment variables are used to build `/etc/tor/torrc-defaults'. For more advanced configuration you ca...


Near line 89: Possible missing comma found.
Context: ...ect[6] ADDR[/MASK][:PORT]". If /MASK is omitted then this policy just applies to the ho...


Near line 145: Consider adding a comma here.
Context: ...o work with an IPv6 address. # Feedback Please report any problems as issues on github...

Markdownlint (14)
README.md (14)

29: Expected: dash; Actual: asterisk
Unordered list style


73: Expected: 0 or 2; Actual: 1
Trailing spaces


81: Expected: 0 or 2; Actual: 1
Trailing spaces


27: Expected: 1; Actual: 2
Multiple consecutive blank lines


28: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


145: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


13: null
Multiple top-level headings in the same document


28: null
Multiple top-level headings in the same document


33: null
Multiple top-level headings in the same document


145: null
Multiple top-level headings in the same document


29: null
Lists should be surrounded by blank lines


146: null
Bare URL used


55: null
Spaces inside code span elements


89: Missing link or image reference definition: ":port"
Reference links and images should use a label that is defined

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@svengo
Copy link
Owner Author

svengo commented May 23, 2024

@coderabbitai review

Copy link

coderabbitai bot commented May 23, 2024

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Outside diff range and nitpick comments (1)
README.md (1)

Line range hint 91-91: Consider adding a comma after "ADDR[/MASK]" for clarity.

- "accept[6]|reject[6] ADDR[/MASK][:PORT]"
+ "accept[6]|reject[6] ADDR[/MASK], [:PORT]"
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between cf6d475 and ff6c73e.
Files selected for processing (1)
  • README.md (3 hunks)
Additional Context Used
LanguageTool (2)
README.md (2)

Near line 91: Possible missing comma found.
Context: ...ect[6] ADDR[/MASK][:PORT]". If /MASK is omitted then this policy just applies to the ho...


Near line 148: Consider adding a comma here.
Context: ... work with an IPv6 address. # Feedback Please report any problems as issues on github...

Markdownlint (15)
README.md (15)

75: Expected: 0 or 2; Actual: 1
Trailing spaces


83: Expected: 0 or 2; Actual: 1
Trailing spaces


13: Expected: 1; Actual: 2
Multiple consecutive blank lines


28: Expected: 1; Actual: 2
Multiple consecutive blank lines


34: Expected: 1; Actual: 2
Multiple consecutive blank lines


147: Expected: 1; Actual: 2
Multiple consecutive blank lines


29: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


148: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


14: null
Multiple top-level headings in the same document


29: null
Multiple top-level headings in the same document


35: null
Multiple top-level headings in the same document


148: null
Multiple top-level headings in the same document


30: null
Lists should be surrounded by blank lines


149: null
Bare URL used


91: Missing link or image reference definition: ":port"
Reference links and images should use a label that is defined

Additional comments not posted (1)
README.md (1)

30-30: Update the Dockerfile link to match the new Alpine version.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between ff6c73e and d69f876.
Files selected for processing (1)
  • README.md (4 hunks)
Additional Context Used
LanguageTool (3)
README.md (3)

Near line 30: Loose punctuation mark.
Context: ...sponding Dockerfile links - [latest, 0.4.8.11](https://github.com/svengo/d...


Near line 56: Possible missing comma found.
Context: .../tor/torrc-defaults. For more advanced configuration you can edit the /data/torrc` configur...


Near line 90: Possible missing comma found.
Context: ...ect[6] ADDR[/MASK][:PORT]". If /MASK is omitted then this policy just applies to the ho...

Markdownlint (3)
README.md (3)

13: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time


27: Expected: 1; Actual: 2
Multiple consecutive blank lines


90: Missing link or image reference definition: ":port"
Reference links and images should use a label that is defined

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@svengo svengo self-assigned this May 23, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

1 similar comment
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between d69f876 and 3e0b6d8.
Files selected for processing (3)
  • .github/workflows/codacy.yml (1 hunks)
  • README.md (4 hunks)
  • docker-compose.yml (1 hunks)
Files skipped from review due to trivial changes (2)
  • .github/workflows/codacy.yml
  • docker-compose.yml
Additional Context Used
LanguageTool (2)
README.md (2)

Near line 29: Loose punctuation mark.
Context: ...sponding Dockerfile links - [latest, 0.4.8.11](https://github.com/svengo/d...


Near line 89: A comma might be missing here.
Context: ...host given. Instead of giving a host or network you can also use "*" to denote the univ...

Markdownlint (1)
README.md (1)

89: Missing link or image reference definition: ":port"
Reference links and images should use a label that is defined

GitHub Check Runs (1)
Codacy Static Code Analysis action_required (1)

README.md: [notice] 89-89: README.md#L89
Missing link or image reference definition: ":port"

Additional comments not posted (1)
README.md (1)

Line range hint 69-147: The environment variable descriptions are clear and detailed.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@svengo svengo added enhancement dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code docker Pull requests that update Docker code labels May 23, 2024
@svengo svengo changed the title Update Dockerfile Bump alpine from 3.19.1 to 3.20.0 May 23, 2024
@svengo svengo changed the title Bump alpine from 3.19.1 to 3.20.0 Bump alpine from 3.19.1 to 3.20.0 and other updates May 23, 2024
@svengo svengo merged commit 924d1eb into main May 23, 2024
4 checks passed
@svengo svengo deleted the update/alpine-3.20.0 branch May 23, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code enhancement github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant